Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download nltk files in build step #1023

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

Fluder-Paradyne
Copy link
Collaborator

Description

Download nltk files in build step

Related Issues

image

Solution and Design

Checked the running image and found that nltk downloads two files 'averaged_perceptron_tagger' and 'punkt'
so we are downloading and keeping these files in the build step itself

Test Plan

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@Fluder-Paradyne Fluder-Paradyne changed the base branch from main to dev August 10, 2023 10:31
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@Tarraann Tarraann merged commit 240912f into dev Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants