-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement type safety #7
Conversation
@maraisr since you're one of the people I know uses this, do you have any feedback? Does this look good to you at a high-level? |
This is such an wonderful pull request! 🎉 Thank you so much!! Was messing around with it, and stumbled upon this nugget. Being able to detect a single output vertex is such a major win for stability and assurance. I'd say ship it! 🚀 My only critique (though pales in comparison to the wins) is that I was unable to get autocomplete for dependencies, but its no biggy. Examplelet get = grfn({
get_post,
get_comments: [get_comments, ['get_post']],
get_author: [get_author, ['get_post']],
format: [
(comments: string, post: string, author: string) => {
return {
comments,
post,
author
};
},
['get_comments', 'get_post', 'get_au ▌']
// ^ expected intellisense to provide me with "get_author"
]
});
let result = await get('my-post');
console.log(`result: %o`, result); |
Glad it's working well for you! Agreed that autocomplete for dependencies would be nice. Might very well be possible to support... |
Co-authored-by: Marais Rossouw <[email protected]>
grfnviz
since it's a pain to maintain and no one seems to be using it