view_curses: do not force black background #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a call to use_default_colors, ncurses will assume that color 0 (usually black) is the same as the background color of the terminal. This assumption is not necessarily true, the user might be running a terminal with any background (even white or a light color) while the color palette has black at index 0. To avoid overriding the background color for the entire window without a good reason, invoke use_default_colors after start_color.
|
Thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a call to use_default_colors, ncurses will assume that color 0
(usually black) is the same as the background color of the terminal.
This assumption is not necessarily true, the user might be running a
terminal with any background (even white or a light color) while the
color palette has black at index 0.
To avoid overriding the background color for the entire window without a
good reason, invoke use_default_colors after start_color.