Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line jumps not correctly skipped by the SRT parser #30

Closed
Unknow-404 opened this issue Aug 4, 2022 · 4 comments
Closed

Line jumps not correctly skipped by the SRT parser #30

Unknow-404 opened this issue Aug 4, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Unknow-404
Copy link

Subtitles name found: Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\CHS\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_CHS.txt converted to ASS C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\CHT\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_CHT.txt converted to ASS C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\DE\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_DE.txt converted to ASS C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\EN\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_EN.txt converted to ASS C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\ES\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_ES.txt converted to ASS C:\Users\{UserName}\Downloads\GICutscenes\GenshinData\Subtitle\FR\Cs_Inazuma_EQ4002207_ShikishogunRecalling_Boy_FR.txt converted to ASS Unhandled exception: System.Exception: Dialogue block doesn't start with a number at GICutscenes.FileTypes.ASS.ParseSrt() at GICutscenes.Program.MergeFiles(String outputPath, String basename, String engine, Boolean subs) at GICutscenes.Program.BatchDemuxCommand(DirectoryInfo inputDir, DirectoryInfo outputDir, String engine, Boolean merge, Boolean subs, Boolean noCleanup) at GICutscenes.Program.<>c.<<Main>b__1_1>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Invocation.AnonymousCommandHandler.InvokeAsync(InvocationContext ) at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass18_0.<<UseParseErrorReporting>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass13_0.<<UseHelp>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseVersionOption>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass20_0.<<UseTypoCorrections>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__19_0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<<UseParseDirective>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__6_0>d.MoveNext() --- End of stack trace from previous location --- at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass9_0.<<UseExceptionHandler>b__0>d.MoveNext()

@Unknow-404
Copy link
Author

What is the problem?

@ToaHartor
Copy link
Owner

ToaHartor commented Aug 4, 2022

Okay so this error happened on the language after FR, so ID. Pretty sure it's because the srt parser doesn't handle a specific case. You will be able to fix it by removing the double line jumps.

Try to have this

7
00:00:24,150 --> 00:00:25,825
"pencapaian tertinggi" ini?

8
00:00:26,875 --> 00:00:28,200
Mengapa begitu gelisah

Instead of this

7
00:00:24,150 --> 00:00:25,825
"pencapaian tertinggi" ini?


8
00:00:26,875 --> 00:00:28,200
Mengapa begitu gelisah

I'll try to make a fix that might be released for the next version, but tbh it's mainly due to MHY not being able to make correctly formatted subtitles.

@ToaHartor ToaHartor added the bug Something isn't working label Aug 4, 2022
@ToaHartor ToaHartor changed the title Some problems Line jumps not correctly skipped by the SRT parser Aug 4, 2022
@Unknow-404
Copy link
Author

OK, thanks!

@ToaHartor
Copy link
Owner

Should be fixed in the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants