merge improvements from fork #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is system-related, not yunohost-related
✅Resolve "remove admin users feature" Closes TheRojam#1 See merge request lydra/yunohost/ansible-yunohost!2
Resolve "ci: add ansible lint and checks" Closes TheRojam#4 See merge request lydra/yunohost/ansible-yunohost!1
refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use. refactor: remove useless comment doc: Readme in English and French
✅Resolve "refactor vars" Closes TheRojam#2 and sylvainar#9 See merge request lydra/yunohost/ansible-yunohost!3
Shell module is not needed here. According to various sources (https://www.youtube.com/watch?v=57gAqKvAKck or https://stackoverflow.com/questions/56663332/difference-between-shell-and-command-in-ansible) it is not useful to use shell ansible module when not working with operands. Therefore I have decided to switch every actions to command module, more secure. Ansible-lint says "Shell should only be used when piping, redirecting or chaining commands"
✅Resolve "Use command module" Closes #10 See merge request lydra/yunohost/ansible-yunohost!6
…pport latest ansible versions Ansible-lint: ``` Include has some unintuitive behaviours depending on if it is running in a static or dynamic in play or in playbook context, in an effort to clarify behaviours we are moving to a new set modules (ansible.builtin.include_tasks, ansible.builtin.include_role, ansible.builtin.import_playbook, ansible.builtin.import_tasks) that have well established and clear behaviours. This module will still be supported for some time but we are looking at deprecating it in the near future. ``` Fix: I have decided to go for ansible include_tasks module because it is more versatile and on a par with this module (for more info about differences between new modules, see [here](https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_module.html)
…ster' ✅Resolve "ansible include module is to be deprecated" Closes #14 See merge request lydra/yunohost/ansible-yunohost!7
- fix: [201] Trailing whitespace REMOVED - fix: meta-no-tags: Use 'galaxy_tags' rather than 'categories' REPLACED + role in Debian 10 only - fix: [601] Don't compare to literal True/False FIXED
…ster' ✅Resolve "fix: ci lint" Closes #12 See merge request lydra/yunohost/ansible-yunohost!5
…galaxy + lydra is author of this role
✅Resolve "GitHub default branch" Closes #23 See merge request lydra/yunohost/ansible-yunohost!11
Resolve "Add badges on readme for github" Closes #18 See merge request lydra/yunohost/ansible-yunohost!10
Resolve "doc: change ansible id" Closes #24 See merge request lydra/yunohost/ansible-yunohost!12
Resolve "doc: review" Closes sylvainar#8 See merge request lydra/yunohost/ansible-yunohost!8
✅Resolve "doc: licence information" Closes #15 See merge request lydra/yunohost/ansible-yunohost!9
✅Resolve "default folder instead of defaultS" Closes #30 See merge request lydra/yunohost/ansible-yunohost!13
✅Resolve "add smtp relay" Closes #31 See merge request lydra/yunohost/ansible-yunohost!14
Resolve "feat: add app post_install" Closes #32 See merge request lydra/yunohost/ansible-yunohost!16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.