Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

181 leaflet container #264

Merged
merged 5 commits into from
Mar 21, 2018

Conversation

jkwening
Copy link
Contributor

Issue Number:

#181

Issue Description:

From screen, route to map with per selected/submitted search query.

Summary of solution:

  1. Heavy refactor of ~/client/src/components/LeafletOsmMap/index.js abstracting out marker creation/management code snippets into re-useable functions.
  2. Use google geolocation when device geolocation fails - I seem to be having problems since upgrading chrome.
  3. Hoist searchResult outcome to client app.js in order to pass home screen result back to map view during routing

Can this issue be closed?

yes - in favor of more specific issues based on current app state

Should any new issues be added as a result of this solution?

  • style search result list

Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.

Thanks for contributing!

@motosharpley motosharpley merged commit 7c437fe into TheDevPath:development Mar 21, 2018
@jkwening jkwening deleted the 181-leaflet-container branch March 22, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants