181 search results #259
Merged
181 search results #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route selected search result from home screen to map view. New feature implemented but have some unexpected bugs that need resolving. Additionally it seems Chrome update is causing geolocation to timeout unexpectedly - need to look into further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
#181
Issue Description:
implemented but have some unexpected bugs that need resolving.
unexpectedly - need to look into further. Update: I think I resolved by adding timeout, maximum age, and setting enableHighAccuracy = false.
Summary of solution:
Connecting search from home page to maps view is leading to spaghetti code due to (p)react's uni-directional flow of state. Current implementation requires implementing passing data across siblings which is causing redundancies or having to hoist map related logic up to app.js level. For simplicity purposes and cleaner code base, going to transition to flux pattern via redux.
Action: merging current working code with minor bugs into new "redux" branch instead of development.