Use custom commands instead of observers for spawning #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alice-i-cecile is this what you had in mind for the simple but limited spawning? Or would you prefer if I used a struct |
benfrankel
requested changes
Aug 8, 2024
src/demo/player.rs
Outdated
Comment on lines
34
to
35
| /// Command to spawn the player character. | ||
| /// We can add fields to this struct if we need data for spawning. |
There was a problem hiding this comment.
Suggested change
| /// Command to spawn the player character. | |
| /// We can add fields to this struct if we need data for spawning. | |
| /// A command to spawn the player character. |
I don't like the second line here personally. There are a lot of things the user could do to expand on the template, and we're not going to list them all. At the very least this doesn't make sense as a doc comment.
There was a problem hiding this comment.
We do however mention things that have a very high probability of coming up and are low-hanging expansions.
I want to keep this comment somewhere in the file, preferably around the struct.
Moved the comment into the struct: d2c59b6 (#242)
Co-authored-by: Ben Frankel <[email protected]>
benfrankel
approved these changes
Aug 8, 2024
benfrankel
reviewed
Aug 8, 2024
benfrankel
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #203
Alternative to #231
Does not help with #223.