Linter: Support Bevy 0.15 #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both have been moved around internally, so we need to update our paths! :)
BD103
added
A-Linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the linter to support Bevy 0.15. As #138 has not yet been implemented, Bevy 0.14 support is being dropped.1
Overall, it was surprisingly simple. I bumped the version of Bevy we use in testing, then fixed any errors. The UI tests are so rigid that even the slightest quiver could cause them to fail, which in this case is a good thing!
The one thing of note is that I'm keeping support for
World::many_entities()andmany_entities_mut()inbevy::panicking_world_methodseven though they are deprecated. Sincepanicking_methodsis likely a lint that would be denied in projects, I don't want panicking methods to slip by just because someone added#[allow(deprecated)]while migration their project. Once these methods are completely removed from Bevy, we'll remove them from the linter.Footnotes
I hope this won't be permanent, though. If all goes to plan, support for 0.14 will be re-added before the next release of
bevy_lint! ↩