Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Review data collection pre-session #52

Merged
merged 2 commits into from
May 25, 2023

Conversation

helenelajous
Copy link
Collaborator

Adds more specific details about the settings before starting the scanning session

@helenelajous
Copy link
Collaborator Author

Lines 80 to 182 refer to the setting of the ET: I think there should be a dedicated section (now, "INSIDE the scanner room" and "Back OUTSIDE THE SCANNER ROOM (control room)" are at the same level as "Setting up the eye-tracker").

Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (added suggestions to make the code more readable and the instructions hopefully more clear - no red mushroom buttons involved this time)

docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
@oesteban oesteban merged commit b2b4105 into mkdocs May 25, 2023
@oesteban oesteban deleted the enh/review-data-collection-pre-session branch May 25, 2023 11:41
@helenelajous
Copy link
Collaborator Author

helenelajous commented May 25, 2023

Minor comments:

  • I would remove mention of button 3
  • line 26: would it be possible to have the icon of a locker in open lock position instead?
  • I would include the current sections "INSIDE the scanner room" and "Back OUTSIDE THE SCANNER ROOM (control room)" as subsections of the section "Setting up the eye-tracker"

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants