Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH : complete scanning protocol and miscalleneous #47

Merged
merged 4 commits into from
May 25, 2023
Merged

ENH : complete scanning protocol and miscalleneous #47

merged 4 commits into from
May 25, 2023

Conversation

celprov
Copy link
Collaborator

@celprov celprov commented May 19, 2023 •
edited
Loading

enh: complete scanning protocol
fix: correct BIOPAC setup with updated trigger setup
enh: add images to save protocol
enh : add scripts to explain the tasks to the participant.

Closes #18

@celprov celprov requested a review from oesteban May 19, 2023 12:42
@celprov celprov force-pushed the enh/improvement_celine2 branch from 9db5877 to a74aa6d Compare May 19, 2023 12:46
@celprov
Copy link
Collaborator Author

celprov commented May 19, 2023

@esavary could you please verify carefully the description of the tasks and that it matches how it looks on psychopy ?

@celprov celprov requested review from esavary and removed request for oesteban May 19, 2023 12:48
esavary
esavary reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@esavary esavary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the description of the tasks. It looks good to me. I just added a few details + corrected a few typos.

docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
docs/data-collection/participant-prep.md Outdated Show resolved Hide resolved
@helenelajous helenelajous self-assigned this May 24, 2023
@oesteban oesteban merged commit cfe8ea1 into TheAxonLab:mkdocs May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esavary esavary esavary left review comments

@oesteban oesteban oesteban left review comments

Assignees

@helenelajous helenelajous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write rundown of the operation of the protocol
4 participants
@celprov @oesteban @esavary @helenelajous