Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docsTool netcoreapp3.1 and better test assertions #179

Merged
merged 10 commits into from
Jan 23, 2020

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Jan 23, 2020

Proposed Changes

  • moves docsTool to netcoreapp3.1 and web sdk
  • fixes reference paths in docsTool with spaces (mostly windows)
  • adds more assertions to the test suite.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...


/polls tested "in PRs"

@TheAngryByrd TheAngryByrd force-pushed the better-test-assertions branch from 0fc2d45 to ec7b48c Compare January 23, 2020 01:02
@TheAngryByrd TheAngryByrd changed the title Better test assertions Move docsTool netcoreapp3.1 and better test assertions Jan 23, 2020
@TheAngryByrd TheAngryByrd merged commit bb85fc1 into master Jan 23, 2020
@TheAngryByrd TheAngryByrd deleted the better-test-assertions branch January 23, 2020 03:14
TheAngryByrd pushed a commit that referenced this pull request Jan 23, 2020
* BUGFIX: Ensures github actions run on pull requests (#177)
* BUGFIX: Fixes Directory.Build.props inheritance in src and test folders(#178)
* BUGFIX: Fixes references with spaces in docsTool and updated to netcoreapp3.1 (#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant