Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly evaluate GITHUB_ACTOR #647

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 5, 2024

Description

git log contains records like:

commit 88946160a3ee9a7770af607162ac8d69b93849a2
Author: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Date:   Tue Jan 2 10:52:28 2024 +0000

    Update DIRECTORY.md [skip actions]

This PR properly evaluates the GITHUB_ACTOR variable in the respective workflow. When this will be merged, I will create similar PR in other repos.

Something to consider

Since user.email is generated using GITHUB_ACTOR, should also user.name be set to GITHUB_ACTOR?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@vil02 vil02 requested review from siriak and imp2002 as code owners January 5, 2024 23:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a1724d) 94.58% compared to head (12ecf53) 94.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files         283      283           
  Lines       22801    22801           
=======================================
  Hits        21566    21566           
  Misses       1235     1235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as draft January 5, 2024 23:20
@vil02 vil02 force-pushed the proper_evaluate_GITHUB_ACTOR branch from a517d25 to 12ecf53 Compare January 5, 2024 23:27
@vil02 vil02 changed the title fix: properly evaluate GITHUB_ACTOR Properly evaluate GITHUB_ACTOR Jan 5, 2024
@vil02 vil02 marked this pull request as ready for review January 5, 2024 23:37
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
Copy link
Member

siriak commented Jan 8, 2024

About the name, let's set it to "Github Actor". Looks reasonable. Could you do that here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants