Add option to pass a timezone into richhandler for log timestamps #3574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Add option to pass a timezone into RichHandler for log timestamps.
Currently, the timestamp produced by RichHandler ignores the "%z" field if it is passed into the dateformat, likely because the datetime object created in RichHandler.render is timezone-naive. We can make it timezone-aware by passing in the expected timezone when calling datetime.fromtimestamp on the log message's timestamp.
The current alternative to doing this would be something like