Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fixed memory leaks in VisibleImage #204

Merged
merged 1 commit into from
Jan 21, 2014
Merged

Conversation

lostmsu
Copy link
Contributor

@lostmsu lostmsu commented Jan 19, 2014

No description provided.

@JakeGinnivan
Copy link
Member

Thanks for this, just a few things (for future reference on contributing, not stopping me pulling this in).

  • Try and keep spaces/tabs consistent. The indenting is slightly out on the changed lines
  • It is best practice to branch from master before commiting changes, then submit the pull request from that feature branch. This allows you to work on multiple fixes at once, and also your master stays clean

Take this is feedback and information for future contributions, thanks for the pull request!

JakeGinnivan added a commit that referenced this pull request Jan 21, 2014
* fixed memory leaks in VisibleImage
@JakeGinnivan JakeGinnivan merged commit 730583d into TestStack:master Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants