Issue155 fixed. #191
Merged
Issue155 fixed. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It would be good to get a UI test for this (extend the current grid tests and put a combobox column in), would you be able to add a test? |
|
Yeah, I'll try to do it. |
|
I prefer not assigning issues, pick things up as you feel like it. The largest bit of work to do is actually getting the tests passing with the UIAComWrapper branch. This branch migrates White to the new COM version of UIA, which is faster and has a bunch of big fixes compared to the managed version white is currently on. White will also be able to support winRT apps once that is done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that grid cell contains combobox, but current condition looks only for Text or CheckBox.
So I updated condition, thus combobox inside grid cell can be found.
By the way, this cell's text can't be accessed via Text property.