Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IUIItem.GetParent<T>() extension method #143

Merged
merged 1 commit into from
Aug 5, 2013

Conversation

ivan-danilov
Copy link
Contributor

Code suggested for #139 works for me, so it could be useful to others as well.

@JakeGinnivan
Copy link
Member

Wonder if this should be an instance method instead of an extension? What do you think?

@ivan-danilov
Copy link
Contributor Author

I asked myself the same, but since the method is workable against any implementation of IUIItem interface - I think it should be an extension method. Instance method will be available for UIItem only and adds another responsibility for any implementer of the interface.
More philosophical than real reason maybe, but nevertheless :)

@JakeGinnivan
Copy link
Member

Yeah, good call

JakeGinnivan pushed a commit that referenced this pull request Aug 5, 2013
Added IUIItem.GetParent<T>() extension method
@JakeGinnivan JakeGinnivan merged commit a5b4c40 into TestStack:master Aug 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants