fix: dialog传入closeBtn为false，依旧渲染了关闭按钮元素，可以响应关闭事件 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaishi
reviewed
Feb 23, 2022
|
|
|
改动会影响snapshot 需要更新成符合预期的snapshot |
|
了解，我修复一下~ |
…nto feature/dialog/closentn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？dialog组件bug
🔗 相关 Issue
💡 需求背景和解决方案
问题：传入的closeBtn为false，依然渲染了span元素，虽然不可见，但是可以响应鼠标事件，如图：
修改方法：如图
📝 更新日志
fix(dialog): 传入closeBtn为false，依旧渲染了关闭按钮元素
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单