New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): trigger keydown event #381

Merged

chaishi merged 2 commits into develop from fix/drawer-keydown

Feb 9, 2022

Collaborator

uyarn commented Feb 9, 2022 •

edited

Loading

🤔 这个 PR 的性质是？

修复drawer组件esc相关事件触发问题

🔗 相关 Issue

fix: 【drawer】组件按下 esc 事件不触发，导致 closeOnEscKeydown onEscKeydown 等都不生效 #380

💡 需求背景和解决方案

tabindex需要设置 div元素才可以触发keydown事件，refer to:https://developer.mozilla.org/zh-CN/docs/Web/HTML/Global_attributes/tabindex

📝 更新日志

fix(drawer): 修复drawer组件keydown相关事件不触发的问题
本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
Changelog 已提供或无须提供


          fix(drawer): trigger keydown event

e929850

Contributor

github-actions bot commented Feb 9, 2022 •

edited

Loading


          chore: update test

f925bdc

chaishi reviewed

View reviewed changes

src/drawer/drawer.tsx Show resolved Hide resolved

chaishi approved these changes

View reviewed changes

chaishi merged commit f7f607d into develop

chaishi deleted the fix/drawer-keydown branch

February 9, 2022 06:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet