-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Input和Collapse组件增加节点类名 #1530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1530 +/- ##
===========================================
+ Coverage 57.94% 61.95% +4.00%
===========================================
Files 407 655 +248
Lines 15371 15838 +467
Branches 2931 2826 -105
===========================================
+ Hits 8907 9812 +905
+ Misses 6187 5735 -452
- Partials 277 291 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
uyarn
reviewed
Sep 20, 2022
uyarn
approved these changes
Sep 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
问题1:Input组件聚焦时,父级节点无法通过类变化监听到从而修改样式
解决方案:聚焦时在父级添加t-input__wrapper--focused类
问题2:Collapse-panel组件的header内容直接渲染,没有父级包裹,在做ie兼容时无法针对对应的部分编写样式
解决方案:在header中添加left、content、right三个父级盒子包裹左、中、右的内容
📝 更新日志
fear(Collapse): 增加节点和类名处理IE样式
fix(InputNumber): 处理0比较的异常 #common850
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单