Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 移除 valueType api #1510

Merged
merged 2 commits into from
Sep 15, 2022
Merged

feat: 移除 valueType api #1510

merged 2 commits into from
Sep 15, 2022

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Sep 14, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(DatePicker): 废弃 valueType api,提供 dayjs 封装对象供用户自定义格式化数据

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

完成

@honkinglin honkinglin force-pushed the feat/datepicker/valueType branch from 7dcfca3 to 033d399 Compare September 14, 2022 12:27
@honkinglin honkinglin force-pushed the feat/datepicker/valueType branch from 033d399 to 2e42f4f Compare September 14, 2022 12:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1510 (e1c5a50) into develop (492d477) will increase coverage by 3.63%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop    #1510      +/-   ##
===========================================
+ Coverage    57.94%   61.58%   +3.63%     
===========================================
  Files          407      655     +248     
  Lines        15371    15826     +455     
  Branches      2931     2820     -111     
===========================================
+ Hits          8907     9746     +839     
+ Misses        6187     5790     -397     
- Partials       277      290      +13     
Impacted Files Coverage Δ
src/alert/_usage/index.vue 0.00% <ø> (ø)
src/affix/affix.tsx 40.00% <80.00%> (+0.93%) ⬆️
src/alert/_example/icon.vue 100.00% <100.00%> (ø)
src/range-input/range-input-popup-props.ts 25.00% <0.00%> (-75.00%) ⬇️
src/grid/row-props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/select/util.ts 65.00% <0.00%> (-26.67%) ⬇️
src/select/props.ts 54.54% <0.00%> (-20.46%) ⬇️
src/date-picker/props.ts 53.84% <0.00%> (-16.16%) ⬇️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/select/optionGroup.tsx 31.57% <0.00%> (-9.60%) ⬇️
... and 439 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaosansiji xiaosansiji merged commit 95e1f35 into develop Sep 15, 2022
@xiaosansiji xiaosansiji deleted the feat/datepicker/valueType branch September 15, 2022 03:03
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants