Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update message demo #1455

Merged
merged 2 commits into from
Sep 4, 2022
Merged

chore: update message demo #1455

merged 2 commits into from
Sep 4, 2022

Conversation

code-x2022
Copy link
Contributor

@code-x2022 code-x2022 commented Sep 3, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • chore(message): 使用spac组件替换demo

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #1455 (b2b8ffd) into develop (492d477) will increase coverage by 2.60%.
The diff coverage is 90.99%.

@@             Coverage Diff             @@
##           develop    #1455      +/-   ##
===========================================
+ Coverage    57.94%   60.54%   +2.60%     
===========================================
  Files          407      646     +239     
  Lines        15371    16166     +795     
  Branches      2931     2936       +5     
===========================================
+ Hits          8907     9788     +881     
+ Misses        6187     6084     -103     
- Partials       277      294      +17     
Impacted Files Coverage Δ
src/alert/_example/icon.vue 100.00% <ø> (ø)
src/alert/_usage/index.vue 0.00% <ø> (ø)
src/anchor/_usage/index.vue 0.00% <ø> (ø)
src/avatar/_example/base.vue 100.00% <ø> (ø)
src/avatar/_usage/index.vue 0.00% <ø> (ø)
src/badge/_usage/index.vue 0.00% <ø> (ø)
src/breadcrumb/_example/custom.vue 100.00% <ø> (ø)
src/breadcrumb/_example/dropdown.vue 100.00% <ø> (ø)
src/button/_example/icon.vue 100.00% <ø> (ø)
src/button/_usage/index.vue 0.00% <ø> (ø)
... and 455 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

修改之后这个demo失效了 麻烦再检查一下

@code-x2022
Copy link
Contributor Author

图片

修改之后这个demo失效了 再检查一下

已修改,改为挂载到body上

@code-x2022 code-x2022 requested a review from uyarn September 4, 2022 07:13
@uyarn uyarn merged commit 2383bc4 into Tencent:develop Sep 4, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants