fix(table): 修复可选中行table组件，data为空数据时，默认全选按钮会选中的问题 #1150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaishi
approved these changes
Jul 11, 2022
|
|
chaishi
reviewed
Jul 11, 2022
src/table/hooks/useRowSelect.tsx
Outdated
| @@ -65,12 +65,14 @@ export default function useRowSelect(props: TdPrimaryTableProps) { | |||
|
|
|||
| // eslint-disable-next-line | |||
| function getSelectedHeader(h: CreateElement) { | |||
| const isIndeterminate = intersectionKeys.value.length > 0 && intersectionKeys.value.length < canSelectedRows.value.length; | |||
| const isChecked = intersectionKeys.value.length | |||
There was a problem hiding this comment.
Checkbox 的参数 checked 数据类型是 boolean。
当前的计算方式 可能出现 checked=0，不符合预期，需添加 Boolean 进行数据类型转换
There was a problem hiding this comment.
|
|
hi-zhaoyeqing
force-pushed
the
fix/table-select-all
branch
3 times, most recently
from
3fcf8c7 to
abe8e83
Compare
修复可选中行table组件，data为空数据时，默认全选按钮会选中的问题
hi-zhaoyeqing
force-pushed
the
fix/table-select-all
branch
from
abe8e83 to
8eab365
Compare
|
@chaishi 看起来和你的改动有冲突 |
|
@qdzhaoxiaodao 别误会 应该是你提的时候刚好一直CI有问题 我们在CHANGELOG上说明一下 |
|
@qdzhaoxiaodao #1172 看了一下其实PR有提到是同步你的代码的 然后我们CHANGELOG上补充下是by you |
@qdzhaoxiaodao 不好意思，这个 PR 我提的，是 vue-next 的 pr 合掉了，这边顺手把vue这边处理了，我在 pr 里面有标注着这个 PR 的来源，后续此类修复会在PR合并的时候询问是否有修复 react 和 vue2 的意愿。 |
|
了解 |
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复可选中行table组件，data为空数据时，默认全选按钮会选中的问题
🤔 这个 PR 的性质是？
🔗 相关 Issue
#1143
💡 需求背景和解决方案
修复后
原因 对空数据没进行判断 解决方案 对空数据做处理📝 更新日志
fix(table): 修复可选中行table组件，data为空数据时，默认全选按钮会选中的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单