Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): 修复Input 组件动态 切换 type 后不生效的问题 #1148

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

hi-zhaoyeqing
Copy link
Contributor

@hi-zhaoyeqing hi-zhaoyeqing commented Jul 9, 2022

修复Input 组件 切换 type 后不生效的问题,官网 Input 中组件示例 选择 type 切换时 Input 中的 type 不会变化。

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 修复Input 组件 切换 type 后不生效的问题,官网 Input 中组件示例 选择 type 切换时 Input 中的 type 不会变化。
  2. 添加watch
  3. 复现地址:https://tdesign.tencent.com/vue/components/input 示例中切换 type 即可复现

📝 更新日志

  • fix(Input): 修复Input 组件 切换 type 后不生效的问题。

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/input-type-change branch 4 times, most recently from 2ebdc1d to 155c749 Compare July 9, 2022 07:17
修复Input 组件 切换 type 后不生效的问题,官网 Input 中组件示例 选择 type 切换时 Input 中的 type 不会变化。
@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/input-type-change branch from 155c749 to 1653f5c Compare July 9, 2022 07:20
@codecov-commenter
Copy link

Codecov Report

Merging #1148 (1653f5c) into develop (a0db0df) will increase coverage by 1.34%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1148      +/-   ##
===========================================
+ Coverage    57.56%   58.90%   +1.34%     
===========================================
  Files          346      404      +58     
  Lines        12828    15010    +2182     
  Branches      2405     2828     +423     
===========================================
+ Hits          7384     8842    +1458     
- Misses        5200     5897     +697     
- Partials       244      271      +27     
Impacted Files Coverage Δ
src/cascader/interface.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/date-picker/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/drawer/props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/cascader/props.ts 64.28% <0.00%> (-27.39%) ⬇️
src/pagination/props.ts 72.72% <0.00%> (-27.28%) ⬇️
src/affix/affix.tsx 39.06% <0.00%> (-27.01%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fb697...1653f5c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

完成

@xiaosansiji xiaosansiji merged commit d42c8f9 into Tencent:develop Jul 11, 2022
@github-actions github-actions bot mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants