-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: major performance bug in Vue-adapter #5698
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dcee185. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
@Mokshit06 Do you remember why a special proxy merge was needed in the vue adapter? |
@KevinVandy If I remember correctly, It was so because without @OlaAlsaker Can you check if the options still stay reactive even after this change? |
I later found out that it was needed to make the "old" way work (using JS-getters and proxy). But when using Vue's reactivity, it is not needed. So I ended up just disabling it when the data is reactive 😄 |
The
mergeOptions
causes huge performance issues in the Vue-adapter whenever the state of the table is updated. This is probably because it merges proxies within proxies, within proxies etc.As far as I know, there is no need for any special handling of option-merging in the Vue-adapter. Removing it fixes the problem, and the library works like it should.