-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactored core features into their own folders with separate base, types, and utils #5643
Merged
KevinVandy
merged 19 commits into
TanStack:alpha
from
WillsWebsites:chore-column-ordering
Jul 1, 2024
Merged
chore: Refactored core features into their own folders with separate base, types, and utils #5643
KevinVandy
merged 19 commits into
TanStack:alpha
from
WillsWebsites:chore-column-ordering
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillsWebsites
commented
Jul 1, 2024
•
edited
Loading
edited
- Refactored the rest of the core features into their own folders with separate base, types, and utils
- Increased package.json size to 19kb for package because the final refactor with all of them gets up to about 18.5kb
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6781fbc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
WillsWebsites
changed the title
chore: Refactored ColumnOrdering into folder with separate base, types, and utils
chore: Refactored Core Features into their own folders with separate base, types, and utils
Jul 1, 2024
WillsWebsites
changed the title
chore: Refactored Core Features into their own folders with separate base, types, and utils
chore: Refactored core features into their own folders with separate base, types, and utils
Jul 1, 2024
KevinVandy
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.