-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(angular-table): add test case #5568
test(angular-table): add test case #5568
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bd70b62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
I'll try to look into it this evening. I did a fast check and had the same error :/ In my previous experiences I had a similiar issue when node_modules was not clean, for example when multiple angular version were installed. Could this be related to the pnpm v9 and nx update? 🤔 |
Fyi this seems a similar issue |
@KevinVandy I don't know what happened, but I can confirm to you this is an issue related to some installed deps issue After doing the below steps in order, I'm now able again to run the examples without any issues :/
find . -path '*/node_modules/*' -delete
find . -path '*/build/*' -delete
I updated all package.json in order to have the same installed angular version (17.3.9) IMPORTANTThis thing make me crazy 😄 Updating angular with the same version is not enough. I have to remove also pnpm-lock.yaml and recreate everything from scratch. Unfortunately this cause some issues while building the qwik demos which break the CI (look to the previous run error https://github.com/TanStack/table/actions/runs/9197713380) EDIT 2Everything seems working in my machine and in the CI after |
I'm introducing some test cases to check the FlexRenderDirective and createAngularTable behaviors.
The setup is the same of @tanstack/angular-query, so we are currently using vitest and @analogjs plugin. We can may add in the future some test with angular-testing-library to do some rendering testing like the react package
I have found somes issues to the proxy implementation:
getCoreRowModel
key in table
were throwing an error due to the function prototype, so I've updated the proxy target to an arrow functionIn a previous commit we also removed the Signal signature to the
createAngularTable
return type. I've reintroduced it since our table object is both signal and proxy