fix(angular-query): fix error NG0600 on Angular v16-v18 #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 36f29b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8419 +/- ##
===========================================
+ Coverage 46.21% 88.61% +42.40%
===========================================
Files 198 16 -182
Lines 7509 281 -7228
Branches 1712 43 -1669
===========================================
- Hits 3470 249 -3221
+ Misses 3664 31 -3633
+ Partials 375 1 -374
|
hakimio
reviewed
Dec 9, 2024
| }) | ||
| }, | ||
| { | ||
| // Set allowSignalWrites to support Angular < v19 | ||
| allowSignalWrites: true, |
There was a problem hiding this comment.
@arnoud-dv
This will log a warning on Angular 19. You should check Angular version before setting this config.
There was a problem hiding this comment.
Didn't expect a warning message for a noop 🤦♂️
Thanks for letting me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect
onCleanupsets a signal which throws an error on Angular < v19 unlessallowSignalWritesis set.