fix(angular-query): improve support for required signals #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e06359e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8409 +/- ##
===========================================
+ Coverage 46.10% 88.61% +42.50%
===========================================
Files 200 16 -184
Lines 7500 281 -7219
Branches 1708 43 -1665
===========================================
- Hits 3458 249 -3209
+ Misses 3667 31 -3636
+ Partials 375 1 -374
|
arnoud-dv
force-pushed
the
refactor/signal-init
branch
3 times, most recently
from
7ec1001 to
9edf927
Compare
arnoud-dv
changed the title
arnoud-dv
force-pushed
the
refactor/signal-init
branch
2 times, most recently
from
9675568 to
63db458
Compare
arnoud-dv
force-pushed
the
refactor/signal-init
branch
from
63db458 to
e06359e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delaying creation of the observer by using a closure to return the observer from a computed signal supports more scenarios where required signals are used in reactive options.
Also part of a fix for #7488. A complete fix would require additional changes to the signal proxy to not evaluate the source computed signal until target computed signals are evaluated.