Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Index.rst #27

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update Index.rst #27

wants to merge 3 commits into from

Conversation

yannickpschroeder
Copy link

Corrected wrong documentation! Key in javascript configuration "dataProcessingService" should be "dataServiceProcessor".

@yannickpschroeder
Update Index.rst
8dbdc7c 
Corrected wrong documentation!
@andreaskienast
Copy link
Member

Thank you for your pull request. Can you please elaborate why you think the configuration is wrong? At least in the develop branch, dataServiceProcessor is deprecated in favor of dataProcessingService.

@andreaskienast andreaskienast added the question Further information is requested label Jan 7, 2021
@yannickpschroeder
Copy link
Author

yannickpschroeder commented Jan 8, 2021 •
edited
Loading

When people find this extension at https://extensions.typo3.org/extension/usercentrics/ and install it via composer with composer req t3g/usercentrics the latest version will be installed, in which dataProcessingService does not exist. At extensions.typo3.org you click on Extension Manual and then on Usage. The given example didn't work for me. So I had to check the Github Repository to find out that "dataProcessingService" will be used in future, but at the moment only "dataServiceProcessor" works for me.

@andreaskienast
Copy link
Member

So this PR relates to already released versions only. Thanks for clarification, I'll re-check this ASAP.

@yannickpschroeder
Update Index.rst
f40482d 
Added warning instead of changing the argument name.
@yannickpschroeder
Copy link
Author

You are totally right. Maybe just adding a warning is the better way than changing the argument name.

@andreaskienast andreaskienast force-pushed the develop branch 2 times, most recently from 72b2606 to e0dedbc Compare February 19, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannickpschroeder @andreaskienast