Move mergeRecordStats in printStats an indentation up #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to two minor improvements: 1) The helper variables are listed in the same place, which makes relevant code be more together: - The assignments are next to each other. - The `print()` calls under the `with open()` are listed together. 2) `mergeRecordStats` should be called for every iteration of the `for plugin` loop; moving it out of the `with open()` should make this ever so slightly more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to two minor improvements:
print()calls under thewith open()are listed together.mergeRecordStatsshould be called for every iteration of thefor pluginloop; moving it out of thewith open()should make this ever so slightly more robust.