fix(gno/dao): add GetMembersJSON to voting module interface & retrieve it from UI #1343
Conversation
…ori-dapp into e2e-test-dao-creation-gno
…dev/mikaelvallenet/feat/register-dao-to-profile-realm
…into dev/mikaelvallenet/feat/gno-display-dao-members
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MikaelVallenet
requested review from
n0izn0iz and
omarsy
and removed request for
n0izn0iz
| @@ -1,12 +1,12 @@ | |||
| import { Buffer } from "buffer"; | |||
There was a problem hiding this comment.
this is not related to this PR, no?
There was a problem hiding this comment.
hmm it just make roles a props and remove the fakeRoles,
but indeed, it's more a step that could be done in another PR or in the one for insert role manager.
Should i open another PR ?
There was a problem hiding this comment.
yes please because the scope of this PR is clearly defined and we can merge the fix right now where the role removal needs a bit more polish when there is no roles IMO
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: n0izn0iz <[email protected]>
…hub.com:TERITORI/teritori-dapp into dev/mikaelvallenet/feat/gno-display-dao-members
Signed-off-by: Norman Meier <[email protected]>
Update & fix the flow to get members
Depends on #1341