fix(gossip): Fix invalid free #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #152. |
0xNineteen
reviewed
Jun 4, 2024
0xNineteen
reviewed
Jun 4, 2024
This involves passing the "message allocator" as a more general "table allocator" at the initialisation site of gossip service, to allow the gossip table to properly free the data with the right allocator.
InKryption
force-pushed
the
ink/fix-invalid-free
branch
from
3aeb705 to
830ab90
Compare
0xNineteen
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves passing the "message allocator" as a more general "table allocator" at the initialization site of gossip service, to allow the gossip table to properly free the data with the right allocator.
Merging this should be high priority, because currently there is a panic in a currently very reachable set of codepaths, which only manifested when testing on mainnet.