Update dashboard.json to use dynamic rate interval #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping. |
|
This needs a DCO sign-off. You can use |
Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current `1m` assumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with `$__rate_interval` which should deal with things automatically in most cases. Signed-off-by: Iustin Pop <[email protected]>
|
Updated, thanks for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/, a fixed rate interval works only in some cases. The current
1massumes that everyone uses the default prometheus scraping interval (15s), but this is not guaranteed, so replace with$__rate_intervalwhich should deal with things automatically in most cases.