Add new chrony serverstats counters to exposed serverstats metrics #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not overly proficient in Go, feedback is much appreciated. |
SuperQ
reviewed
Jul 1, 2024
|
I've created a minimal fix PR: #96. If you want to work on adding additional stats, that'd be great. |
raphaelthomas
force-pushed
the
raphaelthomas/fix-serverstats-chrony-4.5
branch
2 times, most recently
from
10d144c to
de46b26
Compare
|
This needs a DCO sign-off. You can use |
SuperQ
requested changes
Oct 23, 2024
Closed
raphaelthomas
force-pushed
the
raphaelthomas/fix-serverstats-chrony-4.5
branch
from
de46b26 to
f3bcd1a
Compare
SuperQ
reviewed
Oct 27, 2024
Exposes the additional NTP packet timestamping counter serverstats metrics introduced in `chronyd` version `4.4`. Signed-off-by: Raphael Seebacher <[email protected]>
raphaelthomas
force-pushed
the
raphaelthomas/fix-serverstats-chrony-4.5
branch
from
f3bcd1a to
c34ec8f
Compare
SuperQ
added a commit
that referenced
this pull request
Oct 27, 2024
* [CHANGE] Update logging to slog #95 * [CHANGE] Only expose serverstats for correct veersions #100 * [ENHANCEMENT] Add support for Chrony >= 4.5 server stats #87 #96 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Oct 27, 2024
* [CHANGE] Update logging to slog #95 * [CHANGE] Only expose serverstats for correct veersions #100 * [ENHANCEMENT] Add support for Chrony >= 4.5 server stats #87 #96 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Oct 27, 2024
* [CHANGE] Update logging to slog #95 * [CHANGE] Only expose serverstats for correct veersions #100 * [ENHANCEMENT] Add support for Chrony >= 4.5 server stats #87 #96 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the additional NTP packet timestamping counter serverstats
metrics introduced in
chronydversion4.4.