-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands: Add support for the platform key #332
Conversation
This commit adds support for highlighting the platform key in sublime-commands file. Just used the contexts available in sublime-menu syntax file.
This commit adds completions for the platform names in sublime-commands file. Just copied the one used for menu files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a few minor issues. Also, could you add a test, please?
Having platform matching twice is fine for me. While they are similar, I wouldn't say one is referencing the other and they are just using the same concept. We also wouldn't be able to use the correct scope suffix.
Package/Sublime Text Commands/Sublime Text Commands.sublime-syntax
Outdated
Show resolved
Hide resolved
Package/Sublime Text Commands/Sublime Text Commands.sublime-syntax
Outdated
Show resolved
Hide resolved
@FichteFoll regarding the tests, I wanted to add them but it seems the test file is a |
I don't understand the question regarding the test file? The file works like any other, but does not have the |
That makes sense, but what I am saying is suppose I have the |
Did you set the file to use the correct syntax? |
Add tests for the new platform key addition.
Remove non needed comments from command & menu syntax.
Correct incorrect scopes for command & menu syntax.
I realized that the invalid scope probably makes the experience while typing quite uncomfortable and will likely tame that to a generic string instead. |
This PR
platform
key in.sublime-commands
introduced in Build 4094 to support platform specific entries in the command palette.platform
names.This is essentially just a copy of what exists for the
.sublime-menu
file (Both the contexts and the completions). Maybe we need a way to reuse them ?