Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST4] Make editing scheme/theme, OS aware when the corresponding is set to auto. #330

Merged

Conversation

UltraInstinct05
Copy link
Contributor

@UltraInstinct05 UltraInstinct05 commented Jan 31, 2021

This PR adds the ability to make editing color schemes/themes OS aware, when the corresponding settings are set to auto. The quick panel item that is active is selected and has an annotation of Active based on the OS appearance mode.

Resolves #329

…auto.

This commit makes editing color schemes, OS mode aware when the
color_scheme setting is set to the auto mode.
This commit makes editing theme, OS mode aware when the
theme setting is set to the auto mode.
Copy link
Member

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'll hold off merging this until the next build is out and I can properly test, since I'm personally skipping 4096 due to the forced titlebars and I could see others doing that as well, meaning I can't only support the latest build.

plugins/color_scheme_dev.py Outdated Show resolved Hide resolved
@FichteFoll FichteFoll merged commit d1d1ab1 into SublimeText:master Jun 6, 2021
@FichteFoll FichteFoll added this to the 3.3.2 milestone Jun 6, 2021
@UltraInstinct05 UltraInstinct05 deleted the scheme_theme_os_aware branch June 6, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Edit Theme & Scheme dark-/light-aware
2 participants