[ST4] Some changes to build system completions & updating it's syntax. #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `kill_previous` arg to the completions file(s). It was introduced in Build 4092 and meant to kill any previously running builds before starting a new one.
This commit removes completions for phantom related exec args since annotations have now replaced them, so they no longer have any meaning in the new 4xxx builds starting from Build 4050.
This commit 1. Removes the phantoms related exec args for reasons already stated in the previous commit. 2. Adds the `kill_previous` arg for highlighting purposes.
This commit adds the `update_annotations_only` arg to the completions file(s). It was introduced in Build 4050. There seems to have been a corresponding `hide_annotations_only` arg as well but that looks to have been removed in Build 4067 for some reason.
|
I'm wondering whether we should highlight these very specific args in build systems in the first place, since they are primarily used for other invocations of the Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
kill_previous(introduced in 4092 to kill previously running builds) &update_annotations_only(introduced in 4050) to the build system completions file. These are also added to the syntax file for appropriate highlighting.execargs from the completions & syntax file since phantoms are no longer used to show build errors in the buffer from 4050 onwards.