Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST4] Add support for various block_caret_ global settings in color schemes. #317

Merged

Conversation

UltraInstinct05
Copy link
Contributor

@UltraInstinct05 UltraInstinct05 commented Dec 1, 2020

This PR

  1. Adds appropriate completions for various block_caret_ global settings introduced in 4086.
  2. Adds these in the syntax file for appropriate highlighting.

Here is a brief summary of them.

  1. block_caret_corner_style: Controls the corner style of block carets. Valid values are cut, round & square.
  2. block_caret_border: Controls the color of the block caret's border.
  3. block_caret_underline: Controls the color of the block caret inside a selection. The color of the block caret inside a selection will fallback to the color of the caret global if block_caret_underline is not defined.
  4. block_caret_corner_radius: Controls the corner radius of block caret. This value lies in the range [0, 10]

This commit adds completions for various `block_caret_` globals
introduced in Build 4086.
This commit adds appropriate highlighting for `block_caret_` globals
in color schemes.
This commit
1. Adds the `block_caret_corner_radius`.
2. Fixes an issue where `block_caret` wasn't being highlighted.
@UltraInstinct05
Copy link
Contributor Author

Made a commit that adds block_caret_corner_radius and also fixed an issue where block_caret itself wasn't being highlighted.

This commit
1. Places the `block_caret_corner_radius` in the correct context so that
   the integer radius gets the correct scope.
2. Places the `block_caret_corner_style` in the correct context so that
   the corner style gets the correct scope.
@UltraInstinct05
Copy link
Contributor Author

I had previously placed all the block_caret_ settings in the first match of globals-mapping-key context, hence block_caret_corner_radius and block_caret_corner_style wrongly supported color variables in them. I made a commit that rectifies this.

@FichteFoll FichteFoll merged commit 5970641 into SublimeText:master Jan 6, 2021
@FichteFoll
Copy link
Member

Thanks!

@FichteFoll FichteFoll added this to the 3.3.0 milestone Jan 6, 2021
@UltraInstinct05 UltraInstinct05 deleted the block_caret_settings branch January 7, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants