Add missing builtin commands #280
Conversation
toggle_menubar doesn't exist.
There was a problem hiding this comment.
Thanks a bunch. Completeness is nice, so adding the find commands is definitely preferred over omitting them. Using a different command type to document this should work out nicely as well. I verified that the code handles this properly.
I'm a bit unsure on some of the added added metadata here because I seem to remember those having existed earlier, but that might just be me misremembering and I don't have the tools at hand to quickly verify either.
There are definitely ways to automatically find out which commands have been added when, as long as they are referenced in the Default package somewhere, but this will be something for the future.
| show_message: false | ||
| command_type: text | ||
| doc_string: Guess indentation settings from the text content. | ||
| added: 4050 |
There was a problem hiding this comment.
Hm, the command existed before but as a Python implementation. We don't interpret the added data embedded into this document yet, but maybe we should to prevent duplicates.
There was a problem hiding this comment.
There are also some functions which have been removed, like insert_best_completions. There are only few of them, but maybe should mark those as removed in the same way?
There was a problem hiding this comment.
Imo, yes. My hope is that we can use this one location for the command metadata both for PD and some documentation, e.g. the unofficial ones. Not currently, of course, but it makes sense to add such metadata when you notice it or know about it instead of trying to fill back the gaps later.
Closes #268
This PR contains two commits:
The first one adds globally used buitin commands, which are not yet part of the commands_meta_data.
The second proposes to add commands which are used in the find/replace panels only. Not sure whether they should be added or not.