Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color of repo description text #586

Closed
wants to merge 1 commit into from

Conversation

Poorchop
Copy link
Member

The short repository descriptions have had dark text for a while now. In some cases, the text was white but more often than not, it was dark and unreadable.

@Mottie
Copy link
Member

Mottie commented Feb 13, 2018

Hey @Poorchop!

Which page has this problem? The main feed doesn't appear to have dark text.

@Poorchop
Copy link
Member Author

I see it on almost every repo page. For some reason, this repo doesn't have that problem along with some others, but here is one example along with how it looks on my end without the rule:

untitled

@Mottie
Copy link
Member

Mottie commented Feb 13, 2018

Are you using Stylus? GitHub added a definition for text-gray-dark which includes an !important flag.

.text-gray-dark {
  color: #24292e !important;
}

So if our definition, with the same specificity, isn't placed properly it won't override the style. Both Stylus and the original Stylish move the injected stylesheet after the closing </body>, so this shouldn't be an issue. Maybe we just need to increase the specificity of our selectors if this issue keeps popping up.

@silverwind
Copy link
Member

This sounds like a bug in your userstyle engine. Can you post the content of <head> when it happens?

@Poorchop
Copy link
Member Author

Poorchop commented Feb 13, 2018

I'm using Stylish in Firefox 58.0.2.

Both Stylus and the original Stylish move the injected stylesheet after the closing </body>, so this shouldn't be an issue.

The GitHub-Dark stylesheet appears before the body on the problem page but it shows up after </body> on this very page. I guess that means that the problem is with the add-on and not the selector. That doesn't really explain why I don't have the problem when I add the selector in this pull. In any case, it's probably not an issue with this userstyle.

@Poorchop Poorchop closed this Feb 13, 2018
@silverwind
Copy link
Member

A proper fix for these style races will come from openstyles/stylus#248 with the cssOrigin option in Stylus.

@Mottie
Copy link
Member

Mottie commented Feb 13, 2018

That doesn't really explain why I don't have the problem when I add the selector in this pull.

The selector you added has higher specificity.

@Poorchop Poorchop deleted the itemprop branch February 13, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants