forked from graphhopper/graphhopper
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSPS-1243: Implement fail fast option for matrix calculation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDBandit
changed the title
Manage snap errors
RSPS-1243: Implement fail fast option for matrix calculation
Apr 19, 2023
jp-lopez
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job. 💯
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
HDBandit
added a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Example-ticket-to-be-replaced
Implementation details
We added some logic, to take into account possible errors trying to snap (origin/destination points) to the closest edge. Instead of forcing the failure for the whole request, we contemplate the option to fail the computations affected by the erroneous points. So it will be up to the client to ignore the failed computations.
The failed computations are marked in the matrix results with -1.0 (time) and with -1 (distance).
In case you want to specify the
failFast
option to true, the system will fail with the exceptionMultiplePointsNotFoundException
informing all the points not found in the request.By default, the system
GHMatrixRequest
is configured withfailFast=false
as is the compatible behavior expected bySolver
.Examples
Testing
Added unit tests (CI)