Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starship integration running vanila stride and simple e2e tests #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anmol1696
Copy link

Closes: #5

@pyramation
Copy link
Contributor

awesome! @srph this will add end to end testing and simulate the chain so we can test messages on the real chain in a local dev environment

@Anmol1696 is there anything we need to do in order to enable CI here?

@Anmol1696
Copy link
Author

@pyramation once this is merged, CI will be enabled automatically. I have added the github workflow that will run in the gh-action runner itself.

@pyramation
Copy link
Contributor

@srph you want to take a look? this will allow you to write tests with the StrideJS client with the latest Stride binaries, in a local environment w/o having to worry about internet or connectivity, UI, etc.

here is an example of a governance test to give you an idea

@srph
Copy link
Contributor

srph commented Jun 21, 2023

👋🏼 Hey folks, thanks for working on this. Really appreciate it. I just came back from vacation. I'll try to look into it this week - seems like there's some fire to put out as Keplr transactions stopped working at Stride due to recent upgrades.

Will do my best to check this as soon as I can.

@Anmol1696
Copy link
Author

Sounds good. No hurries here, firefighting first.
Let us know we can help.

@srph
Copy link
Contributor

srph commented Jun 26, 2023

Thanks @Anmol1696! Sorry for the late response - it's been one thing after another, but I have some time this week. I'll definitely look into this.

@srph
Copy link
Contributor

srph commented Jul 4, 2023

Hey @Anmol1696 & @pyramation , I really appreciate all your work here. Apologies for the last response!

I'm curious, do you guys have an example where Starship is used extensively for a telescope-generated library? Stride has some e2e tests which covers things from the Frontend-side, so I'm not sure if we'll get value out of this at the moment. However, I am willing to know more how Starship can become valuable for Stride in the near future.

@srph srph self-assigned this Jul 4, 2023
@Anmol1696
Copy link
Author

@srph sorry for late reply. But we have been expanding useage and capabilties of Starship. It is extensively used in Osmojs https://github.com/osmosis-labs/osmojs/tree/main/packages/osmojs/starship, and Telescope itself as well.
We are also expanding it to Cosmjs as well for testing it. We have found a whole set of bugs from testing Osmojs, some of which we have raised even to Cosmos-sdk.

The idea here for StrideJS is to make sure any version of Stridejs or any other libraries used for frontend testing can use Starship to spin up the underlying infra, and then have e2e tests against this a setup with multiple chains. We will also have a frontend testing support being built for MeshSecurity that might be something that could also be used for testing all sort of frontend features as well.

If you already have a more comprehensive testing environment and test cases which you are satisfied by, then we can close the PR as well. If you have any features or requests for us, please let us know as well.

@pyramation
Copy link
Contributor

@srph it's good to use for testing flows, e.g.:

  1. do an IBC TX to send tokens from CosmosHub to Stride
  2. create the ATOM stride token (minting?)
  3. then stake the token, for example

then developers wanting to use Stride can look at the tests, and know how to properly do it, and you can know that your proto and amino encoders are working properly, with an integration test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests with Starship
3 participants