Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding customizable logoutUrl for generic oAuth2 / OpenId connect #2324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PheelTi
Copy link

@PheelTi PheelTi commented Nov 25, 2024

Description

Adding a option to call a logout URL on the remote issuer for oauth/OIDC.

Closes #(issue_number)

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@PheelTi PheelTi requested a review from Frooodle as a code owner November 25, 2024 15:08
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@github-actions github-actions bot added Java Pull requests that update Java code Back End Issues related to back-end development Security Security-related issues or pull requests labels Nov 25, 2024
@dosubot dosubot bot added the enhancement New feature or request label Nov 25, 2024
@Ludy87
Copy link
Contributor

Ludy87 commented Nov 25, 2024

As far as I know, the logout URL is provided by the provider

@PheelTi
Copy link
Author

PheelTi commented Nov 25, 2024

Hello,
yes, that is true, the "generic" config do not use it though.

Depending on the provider, you might pass the client_id, and/or id_token (full token), and/or a redirect URL, and each provider may have specific attribute names for those.

This PR let you specify it for generic configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back End Issues related to back-end development enhancement New feature or request Java Pull requests that update Java code Security Security-related issues or pull requests size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants