Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed timestamps input&output not synchronized #377

Merged
merged 6 commits into from
Apr 16, 2021
Merged

fixed timestamps input&output not synchronized #377

merged 6 commits into from
Apr 16, 2021

Conversation

sirawats
Copy link
Contributor

@sirawats sirawats commented Apr 8, 2021

Basic Info

Info Please fill out this column
Ticket #376
Test on Ubuntu 20.04 ROS2 Foxy, rosbag

Description of contribution in a few bullet points

  • I changed msg.header.stamp in SlamToolbox::updateMap and SlamToolbox::publishTransformLoop from this->now() to latest /scan timestamps (store in ::laserCallback)

Description of documentation updates required from your changes

Future work that may be required in bullet points

SteveMacenski
SteveMacenski reviewed Apr 12, 2021
View reviewed changes
Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes and LGTM

include/slam_toolbox/visualization_utils.hpp Outdated Show resolved Hide resolved
src/slam_toolbox_common.cpp Outdated Show resolved Hide resolved
@sirawats
Copy link
Contributor Author

Thanks!, resolved

SteveMacenski
SteveMacenski requested changes Apr 14, 2021
View reviewed changes
Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please run the linters, I'm seeing several violations

@sirawats
Copy link
Contributor Author

You mean ament_cpplint right? I removed those extra spaces. Thanks for pointing out.

@sirawats sirawats requested a review from SteveMacenski April 16, 2021 10:40
@SteveMacenski SteveMacenski merged commit 749a3b1 into SteveMacenski:ros2 Apr 16, 2021
@SteveMacenski
Copy link
Owner

Thanks!

Jannkar added a commit to Jannkar/slam_toolbox that referenced this pull request Feb 2, 2022
@Jannkar
backport SteveMacenski#377 foxy
0288102
SteveMacenski pushed a commit that referenced this pull request Feb 22, 2022
@janne-karelics @Jannkar
backport #377 foxy (#477)
4786e90 
Co-authored-by: Janne <[email protected]>
NhatTanXT3 added a commit to techtilesg/slam_toolbox that referenced this pull request Nov 8, 2023
@NhatTanXT3
cherry pick (SteveMacenski#377) (SteveMacenski#479)
7385ac6
NhatTanXT3 added a commit to techtilesg/slam_toolbox that referenced this pull request Nov 8, 2023
@NhatTanXT3
Merge pull request #1 from techtilesg/fix_time_sync
b13d4b9 
cherry pick (SteveMacenski#377) (SteveMacenski#479)
@Renbago Renbago mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirawats @SteveMacenski