Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json keywords #1

Merged
merged 1 commit into from
Feb 21, 2016

Conversation

keithamus
Copy link
Contributor

See chaijs/chaijs.github.io#34 for more.

If you're wondering why I want you to add these keywords, here is the reasoning for each one:

  • chai-plugin will let us index your plugin on the next version of the website. If you don't add this to your package.json, you wont be listed on our plugins page.
  • browser will let us know that your plugin supports the browser. Please don't add this keyword if you don't support the browser. If you don't add it we'll assume the plugin does not support browsers.
  • Any other keyword listed below has been listed there, because it was in our plugins.js file which is soon to be removed. If you don't want these keywords in your package.json, that's fine, but seeing as they're in our plugins.js I thought it'd be good measure to give you a chance to add them into your package.json. We'll use them to help filter our plugins page, so it is advisable to add them.

StephenDavidson added a commit that referenced this pull request Feb 21, 2016
Update package.json keywords
@StephenDavidson StephenDavidson merged commit af42ea6 into StephenDavidson:master Feb 21, 2016
@keithamus keithamus deleted the patch-1 branch February 22, 2016 09:40
@keithamus
Copy link
Contributor Author

Hey @StephenDavidson thanks for merging this. FYI this wont be reflected until you cut a release. Could you please just let me know when you do so.

@StephenDavidson
Copy link
Owner

@keithamus Thanks for the pr, the node package version has been bumped and pushed to npm.

@keithamus
Copy link
Contributor Author

Awesome 👍 http://chaijs.com/plugins/chai-signals/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants