Fix: runner listening to 'start' and 'end' events (mochajs#3660)

Stars1233 · Mar 9, 2020 · e1389ef · e1389ef
1 parent 9cbb6f6
commit e1389ef
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/runner.js b/lib/runner.js
@@ -939,7 +939,9 @@ Runner.prototype.run = function(fn) {
     this.emit(constants.EVENT_DELAY_BEGIN, rootSuite);
     rootSuite.once(EVENT_ROOT_SUITE_RUN, start);
   } else {
-    start();
+    Runner.immediately(function() {
+      start();
+    });
   }
 
   return this;

diff --git a/test/unit/mocha.spec.js b/test/unit/mocha.spec.js
@@ -487,6 +487,16 @@ describe('Mocha', function() {
       }, 'not to throw');
     });
 
+    it('should catch the `start` event if no tests are provided', function(done) {
+      var mocha = new Mocha(opts);
+      mocha.run().on('start', done);
+    });
+
+    it('should catch the `end` event if no tests are provided', function(done) {
+      var mocha = new Mocha(opts);
+      mocha.run().on('end', done);
+    });
+
     describe('#reporter("xunit")#run(fn)', function() {
       // :TBD: Why does specifying reporter differentiate this test from preceding one
       it('should not raise errors if callback was not provided', function() {