Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] When replica enter decommission, transaction will nerver complete. (backport #49349) #53986

Open
wants to merge 1 commit into
base: branch-3.4
Choose a base branch
from
Open

[BugFix] When replica enter decommission, transaction will nerver complete. (backport #49349) #53986

wants to merge 1 commit into from
+29 −6

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

  1. Transaction TA writes to a two-replicas tablet and enters the committed state. The tablet's replica are replicaA, replicaB.
  2. replicaA, replicaB generate tasks: PublishVersionTaskA, PublishVersionTaskB. PublishVersionTaskA/PublishVersionTaskB successfully submitted to the beA/beB via RPC.
  3. The machine where beB is located hangs and is not recoverable. Therefore PublishVersionTaskA is finished,PublishVersionTaskB is unfinished.
  4. FE clone replicaC from replicaA, BE report replicaC info. But transactions must rely on replicaA and replicaB, so TA will block on committed.

What I'm doing:

Fixes #52769

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@zhangheihei @mergify
[BugFix] When replica enter decommission, transaction will nerver com…
4ffb443 
…plete. (#49349)

Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: zhanghe <[email protected]>
Signed-off-by: zhanghe <[email protected]>
Co-authored-by: wyb <[email protected]>
(cherry picked from commit 811c51d)
@mergify mergify bot mentioned this pull request Dec 16, 2024
Merged
25 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 16, 2024 10:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhangheihei