Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Modify Coordinator throws Exception to explicit exception type #53984

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Dec 16, 2024

Why I'm doing:

Exception should not be used as a function's throw exception declaration. This is a wrong coding style because the caller cannot handle explicit exceptions correctly.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 6 / 8 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/scheduler/FeExecuteCoordinator.java 0 1 00.00% [136]
🔵 com/starrocks/load/loadv2/LoadMgr.java 0 1 00.00% [416]
🔵 com/starrocks/qe/StmtExecutor.java 3 3 100.00% []
🔵 com/starrocks/qe/scheduler/dag/JobSpec.java 1 1 100.00% []
🔵 com/starrocks/qe/DefaultCoordinator.java 1 1 100.00% []
🔵 com/starrocks/load/loadv2/InsertLoadJob.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@andyziye andyziye merged commit f59d7a4 into StarRocks:main Dec 16, 2024
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants