Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support drop cloud native index for primary key table in Shared-data mode #53971

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Dec 16, 2024

Why I'm doing:

We have now supported cloud-native persistent indexes for primary key tables in a storage-compute separation architecture. However, when an unrecoverable error occurs in the index, we may need to drop the index to trigger its reconstruction.

What I'm doing:

Support drop cloud native index for primary key table in Shared-data mode.
And you can use the following operation to drop cloud native index on tablet:

ALTER TABLE $tableName DROP PERSISTENT INDEX ON $tabletId;

e.g.
alter table pk_test drop persistent index on 10988,10989;

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@sevev sevev requested review from a team as code owners December 16, 2024 08:10
@wanpengfei-git wanpengfei-git requested review from a team December 16, 2024 08:10
@mergify mergify bot assigned sevev Dec 16, 2024
@sevev sevev changed the title [Enhancement] Support drop cloud native index for cloud native index [WIP][Enhancement] Support drop cloud native index for cloud native index Dec 16, 2024
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
@sevev sevev changed the title [WIP][Enhancement] Support drop cloud native index for cloud native index [WIP][Enhancement] Support drop cloud native index for primary key table in Shared-data mode Dec 16, 2024
@sevev sevev changed the title [WIP][Enhancement] Support drop cloud native index for primary key table in Shared-data mode [Enhancement] Support drop cloud native index for primary key table in Shared-data mode Dec 16, 2024
Signed-off-by: sevev <[email protected]>
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 85 / 98 (86.73%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/LakeTableDropPersistentIndexJob.java 21 31 67.74% [42, 43, 59, 64, 72, 73, 93, 94, 95, 96]
🔵 com/starrocks/sql/ast/DropPersistentIndexClause.java 5 7 71.43% [26, 27]
🔵 com/starrocks/alter/SchemaChangeHandler.java 23 24 95.83% [2129]
🔵 com/starrocks/alter/LakeTableAlterMetaJobBase.java 7 7 100.00% []
🔵 com/starrocks/alter/AlterJobExecutor.java 6 6 100.00% []
🔵 com/starrocks/task/TabletMetadataUpdateAgentTaskFactory.java 19 19 100.00% []
🔵 com/starrocks/task/TabletMetadataUpdateAgentTask.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/AstVisitor.java 1 1 100.00% []
🔵 com/starrocks/persist/gson/GsonUtils.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 27 / 27 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/update_manager.cpp 9 9 100.00% []
🔵 be/src/storage/lake/txn_log_applier.cpp 16 16 100.00% []
🔵 be/src/storage/lake/schema_change.cpp 2 2 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants